On Thu, 2015-11-19 at 08:32 +0000, Olaf Hering wrote: > Cosmetics: most of the variables used in vif-bridge are already quoted. > Add quoting also to the remaining shell variables. > > Signed-off-by: Olaf Hering <o...@aepfle.de>
Acked-by: Ian Campbell <ian.campb...@citrix.com. (I imagine much hilarity would ensue all over the place if a Linux netdev actually had a name with a space in it...) > Cc: Ian Jackson <ian.jack...@eu.citrix.com> > Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > Cc: Ian Campbell <ian.campb...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> > --- > tools/hotplug/Linux/vif-bridge | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/hotplug/Linux/vif-bridge b/tools/hotplug/Linux/vif- > bridge > index 3d72ca4..6956dea 100644 > --- a/tools/hotplug/Linux/vif-bridge > +++ b/tools/hotplug/Linux/vif-bridge > @@ -68,7 +68,7 @@ else > fi > > RET=0 > -ip link show dev $bridge 1>/dev/null 2>&1 || RET=1 > +ip link show dev "$bridge" 1>/dev/null 2>&1 || RET=1 > if [ "$RET" -eq 1 ] > then > fatal "Could not find bridge device $bridge" > @@ -77,7 +77,7 @@ fi > case "$command" in > online) > setup_virtual_bridge_port "$dev" > - set_mtu $bridge $dev > + set_mtu "$bridge" "$dev" > add_to_bridge "$bridge" "$dev" > ;; > > @@ -88,7 +88,7 @@ case "$command" in > > add) > setup_virtual_bridge_port "$dev" > - set_mtu $bridge $dev > + set_mtu "$bridge" "$dev" > add_to_bridge "$bridge" "$dev" > ;; > esac _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
