CC Andrew
On Fri, Nov 06, 2015 at 05:05:55PM +0100, Roger Pau Monne wrote:
> Only some minor libxl changes are needed in order to be able to migrate HVM
> guests without a device model, no hypervisor changes are needed.
>
> This change prevents sending the emulator context if the device model
> version is set to none.
>
> Signed-off-by: Roger Pau Monné <roger....@citrix.com>
> Cc: Ian Jackson <ian.jack...@eu.citrix.com>
> Cc: Ian Campbell <ian.campb...@citrix.com>
> Cc: Wei Liu <wei.l...@citrix.com>
> ---
> Changes since v7:
> - Prevent sending the emulator context and xenstore record in
> write_emulator_context_record and write_emulator_xenstore_record.
> - Error out if an emulator record is received for a no-dm guest.
I think this is in line with what you and Andrew discussed in previous
version. If Andrew is happy with this, I'm happy with it, too.
>
> + if (libxl__device_model_version_running(gc, dss->domid) ==
> + LIBXL_DEVICE_MODEL_VERSION_NONE) {
> + emulator_xenstore_record_done(egc, stream);
> + return;
> + }
> +
> rc = libxl__save_emulator_xenstore_data(dss, &buf, &len);
> if (rc)
> goto err;
> @@ -387,6 +396,7 @@ static void emulator_xenstore_record_done(libxl__egc *egc,
> libxl__stream_write_state *stream)
> {
> libxl__domain_suspend_state *dss = stream->dss;
> + STATE_AO_GC(stream->ao);
>
This is redundant.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
