On Thu, 2015-10-29 at 16:27 +0000, Wei Liu wrote: > On Wed, Oct 21, 2015 at 04:23:08PM +0100, Ian Campbell wrote: > > In tree libraries which link against other in tree libraries in a way > > which is opaque to their callers need special handling, specifically > > correct use of -Wl,-rpath-link for the recusively used libraries. > > > > Currently this is rather simple, but up coming changes are going to > > introduce transitive dependencies more than 1 step deep. > > > > Introduce a SHDEPS idiom to contain all the recursive deps for a > > library and include those in both LDLIBS (for linking) and SHLIB (for > > recursive uses). > > > > Try and document the whole thing. > > > > Signed-off-by: Ian Campbell <ian.campb...@citrix.com> > > Acked-by: Ian Jackson <ian.jack...@eu.citrix.com> > > Acked-by: Wei Liu <wei.l...@citrix.com> > > > > > CFLAGS_libxenguest = -I$(XEN_LIBXC)/include $(CFLAGS_xeninclude) > > -LDLIBS_libxenguest = $(XEN_LIBXC)/libxenguest$(libextension) > > -SHLIB_libxenguest = -Wl,-rpath-link=L$(XEN_LIBXC) > > +SHDEPS_libxenguest = > > +LDLIBS_libxenguest = $(SHDEPS_libxenguest) > > $(XEN_LIBXC)/libxenguest$(libextension) > > +SHLIB_libxenguest = $(SHDEPS_libxenguest) -Wl,-rpath > > -link=L$(XEN_LIBXC) > > > > There is an extra "L" preceding XEN_LIBXC. Jan spotted and fixed it in > one of his patch.
Gah, I just replied to Jan claiming to have (inadvertently) spotted this, but I didn't do so at all! Oh well.. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
