El 14/10/15 a les 16.37, Jan Beulich ha escrit: >>>> On 02.10.15 at 17:48, <roger....@citrix.com> wrote: >> Signed-off-by: Roger Pau Monné <roger....@citrix.com> >> Cc: Jan Beulich <jbeul...@suse.com> >> Cc: Andrew Cooper <andrew.coop...@citrix.com> >> --- >> Changes since v6: >> - Return ENODEV in pmtimer_load if the timer is disabled. >> - hvm_acpi_power_button and hvm_acpi_sleep_button become noops if the >> pmtimer is disabled. > > But how are those two features connected? I don't think you can > assume absence of a PM block just because there's no PM timer. > Or if you want to tie them together for now, the predicate needs > to be renamed. > >> - Return ENODEV if pmtimer_change_ioport is called with the pmtimer >> disabled. > > Same here.
What about changing XEN_X86_EMU_PMTIMER into XEN_X86_EMU_PM and this flags disables all PM stuff? Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
