In fact, right now, failing at destroying a cpupool is just not reported to the user in any explicit way.
Let's log an error, as it is customary for xl in these cases. Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com> Reviewed-by: Juergen Gross <jgross@xxxxxxxx> --- Cc: Ian Jackson <ian.jack...@eu.citrix.com> Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Cc: Ian Campbell <ian.campb...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> --- Changes from v1: * avoid changing the return code to EXIT_SUCCESS/FAILURE; that is being taken care of in another series anyway. --- tools/libxl/xl_cmdimpl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 646b281..09a6bd7 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -7584,8 +7584,10 @@ int main_cpupooldestroy(int argc, char **argv) return 1; } - if (libxl_cpupool_destroy(ctx, poolid)) + if (libxl_cpupool_destroy(ctx, poolid)) { + fprintf(stderr, "Can't destroy cpupool '%s'\n", pool); return 1; + } return 0; } _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel