>>> On 27.10.15 at 11:54, <julien.gr...@citrix.com> wrote: > On 27/10/15 10:50, Jan Beulich wrote: >>>>> On 27.10.15 at 11:36, <oleksandr.tyshche...@globallogic.com> wrote: >>> --- a/xen/include/xen/8250-uart.h >>> +++ b/xen/include/xen/8250-uart.h >>> @@ -143,6 +143,15 @@ >>> /* Supplementary control register */ >>> #define UART_OMAP_SCR 0x10 >> >> I think this one is already misplaced here (as is the one in the context >> below the change). > > I don't think so, the omap UART is based on the 8250 and share some > common registers.
Well, if it's that way then the patch is fine, but I then question why we have a separate omap-uart.c. > FWIW, we do the same for ns16550.c which is using the 8250 headers... Sure, because that's (even by its name, especially if considering the intermediate steps) a direct successor. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
