Hello, I just wanted to submit this as one of the bugs, the one which George assigned to me is still pending(it's a patch series), I will submit that ASAP. As for this bug, if I have incorrectly handled it, can you please point out my mistake, I will correct it and re-submit.
Thanks Lasya V On 26 October 2015 at 14:39, Dario Faggioli <dario.faggi...@citrix.com> wrote: > On Sun, 2015-10-25 at 15:32 +0530, Lasya Venneti wrote: > > *This is part of my 'bite sized contribution' to Xen for the > > OutreachY program. > > > > *The change handles the return value of the function xc_dom_allocate, > > if the function returns NULL the function returns -1. It would not be > > useful to jump to err as err would check !dom for NULL. > > > But then you're not closing xs_fd, is that ok? (I'm asking, because I > am not at all a xenstore expert, but, FWIW, it does not feel right to > me). > > > *Changes have been made in the build function in init-xenstore > > -domain.c > > > > *I have taken these discussions for reference: > > https://www.choon.net/forum/read.php?22,3805351,3805351 > > > > Signed-off: Lasya Venneti <comethalle...@gmail.com> > > > Most of this (except the first bullet point, perhaps), and especially > the Signed-off-by (it's 'Signed-off-by:', not 'Signed-off') tag goes in > the patch changelog. > > In fact: > - this looks like a cover letter for a patch series, but there is > only one patch in this case. Usually, when there is only one patch, > you don't need a cover letter (there are exceptions, but I don't > think this qualifies); > - cover letters, no matter whether for series or single patches, do > not become part of the source tree, when the patch (series) is > committed. That is why, information about the patch > content/design/etc. and the tags must live in the changelog. If you > do like this, someone looking at `git log' wouldn't see it. > > Regards, > Dario > -- > <<This happens because I choose it to happen!>> (Raistlin Majere) > ----------------------------------------------------------------- > Dario Faggioli, Ph.D, http://about.me/dario.faggioli > Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) > >
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
