On Fri, Oct 16, 2015 at 06:03:36PM +0800, He Chen wrote: > In non-debug build ASSERT_UNREACHABLE is nop and some compilers will > complain that cbm_code/cbm_data may be used uninitialized in function > psr_set_l3_cbm. Add return after ASSERT_UNREACHABLE to fix it. > > Signed-off-by: He Chen <[email protected]> > --- > xen/arch/x86/psr.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/arch/x86/psr.c b/xen/arch/x86/psr.c > index d3dec3a..c5bdfce 100644 > --- a/xen/arch/x86/psr.c > +++ b/xen/arch/x86/psr.c > @@ -477,6 +477,7 @@ int psr_set_l3_cbm(struct domain *d, unsigned int socket, > > default: > ASSERT_UNREACHABLE(); > + return;
This won't work because this function should return an int. Wei. > } > > spin_lock(&info->cbm_lock); > -- > 1.9.1 _______________________________________________ Xen-devel mailing list [email protected] http://lists.xen.org/xen-devel
