On 10/15/2015 06:30 PM, Roger Pau Monne wrote:
Fix the types used to store the memory parameters of an HVM guest, previously they defaulted to unsigned long on 32bit toolstack builds, which is wrong because a 32bit value cannot hold a 64bit memory address that crosses the 4GB boundary.Signed-off-by: Roger Pau Monné <roger....@citrix.com> Cc: Ian Jackson <ian.jack...@eu.citrix.com> Cc: Ian Campbell <ian.campb...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> --- I don't have a 32bit Dom0 at hand, so if someone can try to create a HVM guests using a 32bit toolstack with more than 4GB of RAM it would be helpful. --- tools/libxc/include/xc_dom.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/libxc/include/xc_dom.h b/tools/libxc/include/xc_dom.h index e52b023..eb3e355 100644 --- a/tools/libxc/include/xc_dom.h +++ b/tools/libxc/include/xc_dom.h @@ -186,11 +186,11 @@ struct xc_dom_image { } container_type; /* HVM specific fields. */ - xen_pfn_t target_pages; - xen_pfn_t mmio_start; - xen_pfn_t mmio_size; - xen_pfn_t lowmem_end; - xen_pfn_t highmem_end; + unsigned long target_pages; + unsigned long long mmio_start;
I'd prefer xen_paddr_t. Juergen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
