On 09/10/15 09:25, Jan Beulich wrote: >>>> On 09.10.15 at 04:56, <konrad.w...@oracle.com> wrote: >> All existing commands ignore the parameter so this does >> not break the ABI. > Does it not? What about the debug mode clobbering of hypercall > argument registers?
That is an implementation detail of the hypervisor. It is irrelevant to guests whether Xen chooses to clobber the spare registers or not. > I think such length indicators need to be part > of the newly added sub-structures instead. I disagree. Having this as a hypercall parameter is ABI compatible, and avoids unnecessary copy_from_guest() ~Andrew > >> This paves the way for expanding the XENVER_ >> hypercall with variable size structures, such as >> "XENVER_build_id: Provide ld-embedded build-ids" >> >> Suggested-by: Andrew Cooper <andrew.coop...@citrix.com> >> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> >> --- >> xen/arch/arm/traps.c | 2 +- > xen/arch/x86/x86_64/entry.S > xen/arch/x86/x86_64/compat/entry.S > > (but that's moot with the comment above) > > Jan > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
