On Thu, 2015-10-01 at 10:32 +0100, Andrew Cooper wrote: > On 01/10/15 08:43, Juergen Gross wrote: > > On 10/01/2015 08:33 AM, Dario Faggioli wrote: > > > On Thu, 2015-10-01 at 07:21 +0200, Juergen Gross wrote:
> > > #define SCHED_OP(opsptr, fn, > > > ...) \ > > > (( (opsptr)->fn != NULL ) ? (opsptr)->fn(opsptr, > > > ##__VA_ARGS__ ) \ > > > : (typeof((opsptr)->fn(opsptr, ##__VA_ARGS__)))0 ) > > > > Aah, yes, of course. > > > > Sorry for the noise. > > Another area ripe for cleanup is these macros. As far as I can tell, > they serve no purpose other than to obscure the code, stop > cscope/ctags > from following the calls, and give the preprocessor a headache. > > A system like we use for the hvm_func pointers and the static inline > wrappers would be far clearer, and also make it obvious that it is > safe > to call with a NULL function pointer. > Happy to add this as well to my TODO list. :-) Thanks and Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
