On Mon, 2015-09-28 at 16:56 +0100, Anthony PERARD wrote:
> This script installs any necessary packages and clones all of the
> OpenStack
> trees which are used by devstack to deploy OpenStack.
>
> Signed-off-by: Anthony PERARD <anthony.per...@citrix.com>
This mostly looks good to me. A few comments.
> + # libvirt is already installed, but not as a package, so avoid
> installation of
> + # the libvirt package with devstack
> + target_editfile($ho, "$builddir/devstack/files/debs/nova", sub {
> + while (<EI>) {
> + next if m/.*libvirt.*/;
> + print EO or die $!;
> + }
> + });
> + target_editfile($ho, "$builddir/devstack/lib/nova_plugins/functions
> -libvirt", sub {
> + while (<EI>) {
> + next if m/install_package.*libvirt.*/;
> + print EO or die $!;
> + }
> + });
Do these end up causing the built_revision_foo to say "-dirty" or anything
like that?
Maybe not because I don't see any calls to store_vcs_revision, which I
think we discussed on an earlier revision?
> + # OpenStack needs access to libvirt from a user.
> + target_cmd_root($ho, <<END);
You could use target_putfilecontents_root_stash for this too I think?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
