On Mon, 2015-09-28 at 21:31 +0100, Julien Grall wrote: > The field names in the IO emulation are really long and use repeatedly > the term handler which make some line cumbersome to read: > > mmio_handler->mmio_handler_ops->write_handler > > Also take the opportunity to do some clean up: > - Avoid "handler" vs "handle" in register_mmio_handler > - Use a local variable to initialize handler in > register_mmio_handler > - Add a comment explaining the dsb(ish) in register_mmio_handler > - Rename the structure io_handler into vmmio because the io_handler > is in fine handling multiple handlers and the name a the fields was > io_handlers. Also rename the field io_handlers to vmmmio
Stray extra "m" in vmmmio. > - Rename the field mmio_handler_ops to ops because we are in the > structure mmio_handler to not need to repeat it > - Rename the field mmio_handlers to handlers because we are in the > vmmio structure > - Make it clear that register_mmio_ops is taking an ops and not an > handle > - Clean up local variable to helpe to understand the code Stray "e" in the last line. > > Signed-off-by: Julien Grall <julien.gr...@citrix.com> Acked-by: Ian Campbell <ian.campb...@citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
