On Tue, 2015-09-29 at 11:05 +0800, Chao Peng wrote: > On Mon, Sep 28, 2015 at 04:46:17PM +0100, Wei Liu wrote: > > On Mon, Sep 28, 2015 at 05:35:56PM +0200, Dario Faggioli wrote:
> > > But since now you're building the full bitmap, we can use > > > libxl_bitmap_count_set(), for that. > > > > > > This may not be a bit deal, but if I'm not wrong, it saves us an > > > hypercall (the PHYSINFO that libxl__count_physical_socket() > > > issues). > > > > > I can pass 0 to libxl_socket_bitmap_alloc() but it will call > hypercall > internally. We need the size for the socketmap anyway before we > allocating it. > Yes, looking better, the number of hypercall we need seems the same in both cases. Furthermore, as Wei said, this is an internal detail / optimization that we can always look into in future, so nevermind, do as you like best. Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
