>>> On 23.09.15 at 05:50, <yang.z.zh...@intel.com> wrote:
> --- a/xen/arch/x86/hvm/vmx/vmx.c
> +++ b/xen/arch/x86/hvm/vmx/vmx.c
> @@ -1678,8 +1678,9 @@ static void __vmx_deliver_posted_interrupt(struct vcpu
> *v)
> {
> unsigned int cpu = v->processor;
>
> - if ( !test_and_set_bit(VCPU_KICK_SOFTIRQ, &softirq_pending(cpu))
> - && (cpu != smp_processor_id()) )
> + if ( !test_bit(VCPU_KICK_SOFTIRQ, &softirq_pending(cpu))
> + && pi_test_on(&v->arch.hvm_vmx.pi_desc)
> + && (cpu != smp_processor_id()))
> send_IPI_mask(cpumask_of(cpu), posted_intr_vector);
> }
> }
So this still removes the setting of the softirq - how can that be
correct (namely in the cpu == smp_processor_id() case)? Did you
perhaps mean
if ( pi_test_on(&v->arch.hvm_vmx.pi_desc)
&& !test_and_set_bit(VCPU_KICK_SOFTIRQ, &softirq_pending(cpu))
&& (cpu != smp_processor_id()))
?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
