>>> On 11.09.15 at 10:29, <feng...@intel.com> wrote: > Move some APIC related macros to apicdef.h, so they can be used > outside of vlapic.c. > > CC: Keir Fraser <k...@xen.org> > CC: Jan Beulich <jbeul...@suse.com> > CC: Andrew Cooper <andrew.coop...@citrix.com> > Signed-off-by: Feng Wu <feng...@intel.com> > --- > v7: > - Put the Macros to the right place inside the file.
Almost: > --- a/xen/include/asm-x86/apicdef.h > +++ b/xen/include/asm-x86/apicdef.h > @@ -57,6 +57,8 @@ > #define APIC_DEST_SELF 0x40000 > #define APIC_DEST_ALLINC 0x80000 > #define APIC_DEST_ALLBUT 0xC0000 > +#define APIC_SHORT_MASK 0xC0000 > +#define APIC_DEST_NOSHORT 0x0 This last one would more naturally go ahead of APIC_DEST_SELF. And both it and ... > @@ -64,6 +66,7 @@ > #define APIC_INT_LEVELTRIG 0x08000 > #define APIC_INT_ASSERT 0x04000 > #define APIC_ICR_BUSY 0x01000 > +#define APIC_DEST_MASK 0x800 ... this one should be zero-padded to match the respective neighbors. With that done Acked-by: Jan Beulich <jbeul...@suse.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
