On Fri, 2015-09-11 at 16:29 +0800, Feng Wu wrote: > CC: Keir Fraser <k...@xen.org> > CC: Jan Beulich <jbeul...@suse.com> > CC: Andrew Cooper <andrew.coop...@citrix.com> > CC: Kevin Tian <kevin.t...@intel.com> > CC: George Dunlap <george.dun...@eu.citrix.com> > CC: Dario Faggioli <dario.faggi...@citrix.com> > Sugguested-by: Dario Faggioli <dario.faggi...@citrix.com> > Signed-off-by: Feng Wu <feng...@intel.com> > Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com> > Ehm, just one thing, for now...
> --- > v7: > - Merge [PATCH v6 16/18] vmx: Add some scheduler hooks for VT-d posted > interrupts > and "[PATCH v6 14/18] vmx: posted-interrupt handling when vCPU is blocked" > into this patch, so it is self-contained and more convenient > for code review. > - Make 'pi_blocked_vcpu' and 'pi_blocked_vcpu_lock' static > - Coding style > - Use per_cpu() instead of this_cpu() in pi_wakeup_interrupt() > - Move ack_APIC_irq() to the beginning of pi_wakeup_interrupt() > - Rename 'pi_ctxt_switch_from' to 'ctxt_switch_prepare' > - Rename 'pi_ctxt_switch_to' to 'ctxt_switch_cancel' > - Use 'has_hvm_container_vcpu' instead of 'is_hvm_vcpu' > - Use 'spin_lock' and 'spin_unlock' when the interrupt has been > already disabled. > - Rename arch_vcpu_wake_prepare to vmx_vcpu_wake_prepare > - Define vmx_vcpu_wake_prepare in xen/arch/x86/hvm/hvm.c > - Call .pi_ctxt_switch_to() __context_switch() instead of directly > calling vmx_post_ctx_switch_pi() in vmx_ctxt_switch_to() > - Make .pi_block_cpu unsigned int > - Use list_del() instead of list_del_init() > - Coding style > ...With soo many changes having done to this patch, I'd say you should have dropped any Acked/Reviewed-by tag! Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel