On Wed, 2015-09-16 at 14:35 +0100, Ian Jackson wrote:
> ./standalone's with_logging function would _log_ errors, but it
> wouldn't exit immediately. As a result, the script would blunder on.
>
> Normally it wouldn't do very much more since most of the with_logging
> calls are the last thing it does - but the exit status would be wrong
> (0, from echo).
>
> As a result, for example, standalone-generate-dump-flight-runvars
> would never properly report make-flight failures.
>
> Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com>
Acked-by: Ian Campbell <ian.campb...@citrix.com>
> ---
> standalone | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/standalone b/standalone
> index 873616a..60b6666 100755
> --- a/standalone
> +++ b/standalone
> @@ -194,6 +194,7 @@ with_logging() {
> rc=${PIPESTATUS[0]}
> if [ $rc -ne 0 ] ; then
> echo "FAILED rc=${rc}" >&2
> + exit $rc
> fi
> }
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
