On Tue, 15 Sep 2015, Stefano Stabellini wrote:
> } else {
> + if (!disks[i].readwrite) {
> + LIBXL__LOG(ctx, LIBXL__LOG_ERROR, "qemu-xen doesn't
> support read-only disk drivers");
> + return ERROR_INVAL;
> + }
> +
Is ERROR_INVAL the right error to return? I get
libxl_dm.c: In function 'libxl__build_device_model_args_new':
libxl_dm.c:807:28: error: return makes pointer from integer without a cast
[-Werror=int-conversion]
return ERROR_INVAL;
^
cc1: all warnings being treated as errors
when I try to build xen with the proposed patch. NULL is returned when
there is a problem in other places in this function.
Michael Young
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
