On 2015/09/15 12:02, Wei Liu wrote: > I don't know this piece of code so my comments might be stupid. > > On Tue, Sep 15, 2015 at 04:29:40PM +0800, Haozhong Zhang wrote: >> This patch removes the address translation in xen-mceinj which >> translates the guest physical address passed-in through the argument >> of '-p' to the host machine address. >> > > Is the translation functionality broken or superseded by hardware > support? What is the reason for removing this piece of (working?) code?
Neither nor. The translation done in xen-mceinj.c doesn't deal with memory addresses above 4G. The fix is to let the hypervisor do the translation. Christoph > > (I haven't looked at the code) > > Wei. > Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger Ust-ID: DE289237879 Eingetragen am Amtsgericht Charlottenburg HRB 149173 B _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
