Robert Ho writes ("[OSSTest Nested v12 01/21] Optimize and re-format previous
code of 'submenu' parsing"):
> * space between ')' and '{'; and after '='
> * omit unnecessary 'define' and '!defined' usage
> * break long '{}' into several lines
These changes are all good.
But }
> if (m/^\s*submenu\s+[\'\"](.*)[\'\"].*\{\s*$/) {
> - $submenu={ StartLine =>$., MenuEntryPath => join ">",
> @offsets };
> + $submenu= { StartLine =>$. };
This drops the setting of MenuEntryPath from $submenu. This isn't
mentioned in the commit message, and (without looking at the code to
double-check) I'm not sure that it's right.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
