>>> On 08.09.15 at 07:38, <feng...@intel.com> wrote: > And consider this is just a debug function, is it that bad to add a > two stage search here? The output is clear and nice in this way.
The primary questions to ask are: How much longer will the function take on a huge system with many guests when using two loops compared with just one? And how much longer will it take someone looking at the output to find the entry (s)he's after, possibly not immediately realizing that it missing among dozens or hundreds of lines of one kind of output means it could be in the other half, far away in the log? Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel