On 05/09/15 00:59, Wei Liu wrote:
The prefix "Memory" is confusing because the numbers shown after that
are referring to frames. They have no bearing on how many pages a domain
actually owns or how many actual pages are processed.
There is a direct bearing on how many pages are processed, by virtue of
the "$X of $Y" later in the line. I think your final phrase is
misleading and should just be dropped.
Also, there are two further places which need "Memory" changing in a
similar way; send_memory_verify() (which itself should probably be
renamed to verify_frames()), and update_progress_string() which is the
companion to the hunk below, but for live migration.
~Andrew
Signed-off-by: Wei Liu <wei.l...@citrix.com>
---
tools/libxc/xc_sr_save.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxc/xc_sr_save.c b/tools/libxc/xc_sr_save.c
index 58667af..924c425 100644
--- a/tools/libxc/xc_sr_save.c
+++ b/tools/libxc/xc_sr_save.c
@@ -659,7 +659,7 @@ static int send_domain_memory_nonlive(struct xc_sr_context
*ctx)
if ( rc )
goto err;
- xc_set_progress_prefix(xch, "Memory");
+ xc_set_progress_prefix(xch, "Frames");
rc = send_all_pages(ctx);
if ( rc )
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
