On 12/08/15 16:05, Jan Beulich wrote: > Tearing down a 1:1 mapping that was never established isn't really nice > (and in fact hits an ASSERT() in p2m_remove_page()). Convert from a > wrapper macro to a proper function which then can take care of the > situation. > > Also take the opportunity to remove the 'page_order' parameter of > clear_identity_p2m_entry(), to make it match set_identity_p2m_entry().
What about identity mapping with 2MB frames? IMO, the RMRR code is incorrect in assuming that only 4K frames will be wanted, but that is a separate issue. As this at least matches the set_identity side of things, and improves the situation, so Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> (I presume you intended to include a SoB tag?) ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
