On Tue, 2015-08-11 at 09:57 +0100, Wei Liu wrote: > On Fri, Aug 07, 2015 at 06:08:25PM +0200, Roger Pau Monne wrote: > > This is a simple fix to make sure libxl__build_hvm returns an error > > code in > > case of failure. > > > > > > > Signed-off-by: Roger Pau Monné <roger....@citrix.com> > > Cc: Ian Jackson <ian.jack...@eu.citrix.com> > > Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > > Cc: Ian Campbell <ian.campb...@citrix.com> > > Cc: Wei Liu <wei.l...@citrix.com> > > Acked-by: Wei Liu <wei.l...@citrix.com>
Unfortunately I think this will result in any valid rc's any path happens to have being discarded in favour of a generic ERROR_FAIL. If we are going to band aid this for 4.6 then I think setting rc = ERROR_FAIL just after the libxl__domain_device_construct_rdm error handling might be better. Even better would be to put the rc = ERROR_FAIL into the various if (ret) blocks. I don't think that would be an unacceptably large patch (it's 3-4 sites from what I can see) and it would be closer to heading in the right direction. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
