El 06/07/15 a les 14.23, Andrew Cooper ha escrit: > On 03/07/15 12:34, Roger Pau Monne wrote: >> This allows having different arch_setup_meminit implementations based on the >> guest type. It should not introduce any functional changes. >> >> Signed-off-by: Roger Pau Monné <roger....@citrix.com> >> Cc: Ian Jackson <ian.jack...@eu.citrix.com> >> Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com> >> Cc: Ian Campbell <ian.campb...@citrix.com> >> Cc: Wei Liu <wei.l...@citrix.com> > > Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> > > However, would you mind doing a cleanup patch which changes the use of > __init. Confusingly given its precedent in hypervisor code, xc_dom.h > has "#define __init __attribute__ ((constructor))". At a first guess, > 'initcall' or even just 'constructor' would be more appropriate names.
Iff you don't mind, I would rather do that after this series. I'm already carrying a non-trivial amount of patches, and doing something like this in the middle of the series would be hard to maintain rebase wise. Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
