On Fri, Jul 24, 2015 at 11:41:17AM +0100, Ian Campbell wrote: > Since 25652f232cbe "tools/libxl: detect and avoid conflicts with RDM" > the build is broken for x86_32 and arm32 with: > > libxl_dm.c: In function ‘libxl__domain_device_construct_rdm’: > libxl_dm.c:349:13: error: format ‘%lx’ expects argument of type ‘long > unsigned int’, but argument 8 has type ‘uint64_t’ [-Werror=format=] > LOG(ERROR, "RDM conflict at 0x%lx.\n", d_config->rdms[i].start); > ^ > libxl_dm.c:352:13: error: format ‘%lx’ expects argument of type ‘long > unsigned int’, but argument 8 has type ‘uint64_t’ [-Werror=format=] > LOG(WARN, "Ignoring RDM conflict at 0x%lx.\n", > > Use PRIx64 for these. > > Signed-off-by: Ian Campbell <ian.campb...@citrix.com> > Cc: Tiejun Chen <tiejun.c...@intel.com>
Acked-by: Wei Liu <wei.l...@citrix.com> > --- > tools/libxl/libxl_dm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c > index 8d103c3..8ac007a 100644 > --- a/tools/libxl/libxl_dm.c > +++ b/tools/libxl/libxl_dm.c > @@ -346,10 +346,11 @@ int libxl__domain_device_construct_rdm(libxl__gc *gc, > continue; > > if (d_config->rdms[i].policy == LIBXL_RDM_RESERVE_POLICY_STRICT) { > - LOG(ERROR, "RDM conflict at 0x%lx.\n", d_config->rdms[i].start); > + LOG(ERROR, "RDM conflict at 0x%"PRIx64".\n", > + d_config->rdms[i].start); > goto out; > } else { > - LOG(WARN, "Ignoring RDM conflict at 0x%lx.\n", > + LOG(WARN, "Ignoring RDM conflict at 0x%"PRIx64".\n", > d_config->rdms[i].start); > > /* > -- > 2.1.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel