On Thu, 16 Jul 2015, Julien Grall wrote: > Hi Stefano, > > On 16/07/2015 16:47, Stefano Stabellini wrote: > >> diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c > > > index 3679293..0a1f903 100644 > > > --- a/drivers/xen/grant-table.c > > > +++ b/drivers/xen/grant-table.c > > > > The arm part is fine, but aren't you missing the change to RPP and SPP? > > SPP has been removed by commit 548f7c94759ac58d4744ef2663e2a66a106e21c5 as it > was unused. > > For RPP, it's used internally so there is no need to switch to XEN_PAGE_SIZE. > Otherwise we will waste 60KB for each internal page allocated (see > gnttab_init).
I see now that RPP is specifically for internal data structures in grant-table.c and it is used consistently. Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
