Wei Liu writes ("[PATCH v3 05/10] libxl: localtime(3) can return NULL"): > Signed-off-by: Wei Liu <wei.l...@citrix.com> ... > t = time(NULL); > tm = localtime(&t); > > + if (!tm) { > + ret = ERROR_FAIL;
You must log something here I think. Otherwise this function generates ERROR_FAIL entirely mysteriously (in this quite unlikely error path). Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel