On Thu, 2015-07-09 at 19:26 +0100, Andrew Cooper wrote: > When a legacy stream is found, it needs to be converted to a v2 stream for the > reading logic. This is done by exec()ing the python conversion utility. > > One complication is that the caller of this interface needs to assume > ownership of the output fd, to prevent it being closed while still in use in a > datacopier. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > CC: Ian Campbell <ian.campb...@citrix.com> > CC: Ian Jackson <ian.jack...@eu.citrix.com> > CC: Wei Liu <wei.l...@citrix.com>
I think various internals should use the libxl__convert_legacy_stream_inuse helper. With that: Acked-by: Ian Campbell <ian.campb...@citrix.com> Perhaps libxl__conversion_helper_state could become empty on !x86? My Ack stands either way. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel