>>> On 07.07.15 at 15:52, <tleng...@novetta.com> wrote: > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -6431,6 +6431,17 @@ int hvm_debug_op(struct vcpu *v, int32_t op) > return rc; > } > > +void hvm_toggle_singlestep(struct vcpu *v) > +{ > + ASSERT(atomic_read(&v->pause_count)); > + > + /* This feature may only be available on Intel CPUs. */ > + if ( !cpu_has_vmx || !hvm_funcs.is_singlestep_supported() )
Same here regarding use of hvm_funcs. And you should use cpu_has_vmx here or in the wrapper - instead the wrapper should check whether the hook is NULL. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel