On 07/07/15 16:50, Ian Campbell wrote: > I'd rather we refactored these checks into some sort of is_valid_irq() > helper which could check vs. nr_lines (which remains the > GICD_TYPER.ITLinesNumber based thing) and the number of LPIs separately. > > Combining the two risks considering interrupt in the 1025..8191 range as > valid and open coding anything more complex than the existing single < > check in all the relevant places isn't going to scale.
I would be fine with that too. Although, I think we need to add a comment on top of gic_number_lines to clearly specify this is not included LPIs. Regards, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
