>>> On 02.07.15 at 14:04, <ben.catter...@citrix.com> wrote:
> Reworked the internals and declaration, applying (un)boxing
> where needed. Converted calls to map_domain_page() to
> provide mfn_t types, boxing where needed.
>
> Signed-off-by: Ben Catterall <ben.catter...@citrix.com>
> Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>
>
> ---
> Changed since v1:
> * Created paddr_to_mfn() and mfn_to_paddr() for both x86 and ARM
> * Converted code to use the new paddr_to_mfn() rather than e.g.
> paddr>>PAGE_SHIFT
This was a bogus change - why can't you use paddr_to_pfn() and
pfn_to_paddr()? And if you needed new macros, they should be
named consistently, i.e. maddr_to_mfn() and mfn_to_maddr().
And perhaps they should then produce/take mfn_t?
> @@ -194,7 +194,7 @@ static void update_pagetable_mac(vmac_ctx_t *ctx)
> {
> if ( page->count_info & PGC_page_table )
> {
> - void *pg = map_domain_page(mfn);
> + void *pg = map_domain_page(_mfn(mfn));
> vmac_update(pg, PAGE_SIZE, ctx);
Please take the opportunity and add the missing blank line in cases
like this.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
