>>> On 29.06.15 at 22:21, <boris.ostrov...@oracle.com> wrote:
> @@ -4929,6 +4928,27 @@ static hvm_hypercall_t *const
> pvh_hypercall64_table[NR_hypercalls] = {
> [ __HYPERVISOR_arch_1 ] = (hvm_hypercall_t *)paging_domctl_continuation
> };
>
> +extern void compat_mmuext_op(void); /* XXX: need proper declaration */
No XXX like this please. Just add a suitable declaration. And in fact
adding it here (with correct arguments, and without the comment)
would seem quite fine to me.
> +static hvm_hypercall_t *const pvh_hypercall32_table[NR_hypercalls] = {
> + HYPERCALL(platform_op),
> + COMPAT_CALL(memory_op),
> + HYPERCALL(xen_version),
> + HYPERCALL(console_io),
> + [ __HYPERVISOR_grant_table_op ] =
> + (hvm_hypercall_t *)hvm_grant_table_op_compat32,
> + COMPAT_CALL(vcpu_op),
> + COMPAT_CALL(mmuext_op),
> + HYPERCALL(xsm_op),
> + COMPAT_CALL(sched_op),
> + HYPERCALL(event_channel_op),
> + [ __HYPERVISOR_physdev_op ] = (hvm_hypercall_t *)hvm_physdev_op_compat32,
> + HYPERCALL(hvm_op),
> + HYPERCALL(sysctl),
> + HYPERCALL(domctl),
> + [ __HYPERVISOR_arch_1 ] = (hvm_hypercall_t *)paging_domctl_continuation
> +};
> +
> +
Just one blank line please.
With these addressed
Acked-by: Jan Beulich <jbeul...@suse.com>
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
