On Mon, 2015-07-06 at 17:26 +0100, Ian Jackson wrote: > George Dunlap writes ("Re: [Xen-devel] [PATCH v3 1/7] libxl: get rid of the > SEDF scheduler"): > > On 07/06/2015 05:17 PM, Dario Faggioli wrote:
> > I probably wouldn't even have bothered saying anything if I hadn't > > already been replying to the e-mail because of the line below. :-) > > Also, while public-facing API comments are only comments (only > documentation), they are quite important. > > A change like this: > > > >>> - mark the SEDF only parameter as deprecated in libxl_types.idl, > > >>> as requested during review. > > warrants dropping an acked/reviewed-by (unless it was requested or > suggested by the reviewer). > Right, makes sense, and I see it now. Thanks. :-) So, while you're here, should I send v4 with the 'budget' field moved up? Thanks and Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel