+shannon
On 21 May 2015 at 17:52, Julien Grall <julien.gr...@citrix.com> wrote:
> On 17/05/15 21:03, Parth Dixit wrote:
>> refactor gic related functions into dt and generic parts
>> this will be helpful when adding acpi support for gic
>>
>> Signed-off-by: Parth Dixit <parth.di...@linaro.org>
>> ---
>> xen/arch/arm/gic-v2.c | 13 ++++++++++---
>> xen/arch/arm/gic.c | 7 ++++++-
>> 2 files changed, 16 insertions(+), 4 deletions(-)
>>
>> diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c
>> index 80acc62..7276951 100644
>> --- a/xen/arch/arm/gic-v2.c
>> +++ b/xen/arch/arm/gic-v2.c
>> @@ -663,7 +663,7 @@ static hw_irq_controller gicv2_guest_irq_type = {
>> .set_affinity = gicv2_irq_set_affinity,
>> };
>>
>> -static int __init gicv2_init(void)
>> +static int __init dt_gicv2_init(void)
>> {
>> int res;
>> const struct dt_device_node *node = gicv2_info.node;
>> @@ -689,6 +689,13 @@ static int __init gicv2_init(void)
>> panic("GICv2: Cannot find the maintenance IRQ");
>> gicv2_info.maintenance_irq = res;
>>
>> + return 0;
>> +}
>> +
>> +static int gicv2_init(void)
>> +{
>> + dt_gicv2_init();
>> +
>
> I forgot it on the first review. dt_gicv2_init is returning an error
> code. You should not ignore it.
>
> If it's not useful (because everything paniced), then the function
> should return void.
>
> Regards,
>
> --
> Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
