so that, if the same config is reused later, the following two (good) things happen: - we do not trip over warnings because node and/or vcpu soft affinity now exist (as a consequence of the successful placement), but numa_placement is still true; - we end up always using the results of the original execution of the placement algorithm, rather than re-running it at each re-use of the same config, which is what most users expects and wants.
This fixes the bug reported here: http://lists.xenproject.org/archives/html/xen-devel/2015-06/msg04454.html Signed-off-by: Dario Faggioli <dario.faggi...@citrix.com> --- Cc: Ian Jackson <ian.jack...@eu.citrix.com> Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Cc: Ian Campbell <ian.campb...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> Cc: Euan Harris <euan.har...@citrix.com> --- tools/libxl/libxl_dom.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c index b9a77a5..8642192 100644 --- a/tools/libxl/libxl_dom.c +++ b/tools/libxl/libxl_dom.c @@ -369,6 +369,15 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid, NULL, &cpumap_soft); libxl_bitmap_dispose(&cpumap_soft); + + /* + * Placement has run, so avoid for it to be re-run, if this + * same config we are using and building here is ever re-used. + * This means that people re-using configs will get the same + * results, consistently, across every re-use, which is what + * we expect most people to want. + */ + libxl_defbool_set(&info->numa_placement, false); } } _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
