On 07/01/2015 06:36 PM, Ian Campbell wrote:
On Wed, 2015-07-01 at 10:05 +0800, Yang Hongyang wrote:
On 06/30/2015 06:52 PM, Ian Campbell wrote:
On Tue, 2015-06-30 at 17:53 +0800, Yang Hongyang wrote:
On 06/30/2015 12:30 AM, Ian Campbell wrote:
On Thu, 2015-06-25 at 14:25 +0800, Yang Hongyang wrote:
introduce enum type libxl_checkpointed_stream in IDL.
rename the last argument of migrate_receive from "remus" to
"checkpointed" since the semantics of this parameter has
changed.
I don't see anything here which is hitting the libxl API layer, it all
looks to be internal to xl. Is that going to change in a future patch
i.e. is something in libxl.h going to now accept a
libxl_checkpointed_stream?
It is stored in restore_params.checkpointed_stream, does this a libxl API layer
structure?
Is that in a later patch? I didn't spot it if so.
It's in the existing code:
xl_cmdimpl.c create_domain()
Ah sorry, since it didn't change it wasn't in the patch and my grep
seems to have missed it.
But wait, libxl_domain_restore_params isn't changed here, shouldn't it
be? Otherwise params.checkpointed_stream is still an int. I suspect some
part of a later patch should appear here instead.
It better to be changed, but I'm not sure if this change will impact the
existing users, if we do not change, there won't be problem at least.
Ian.
2720 if ( restoring ) {
2721 libxl_domain_restore_params params;
2722
2723 libxl_domain_restore_params_init(¶ms);
2724
2725 params.checkpointed_stream = dom_info->checkpointed_stream;
2726 ret = libxl_domain_create_restore(ctx, &d_config,
...
Ian
.
.
--
Thanks,
Yang.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
