The fallback entry in the worstrow search, used when a job has not been run at all, was wrong. Also, fix the doc comment which induced the mistake, and add a comment about the contents of @worst.
Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com> --- v2: Added the comment about @worst. --- sg-report-flight | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sg-report-flight b/sg-report-flight index 6481521..ebb9281 100755 --- a/sg-report-flight +++ b/sg-report-flight @@ -965,7 +965,7 @@ END my $cell_html = sub { my ($ei, $core_only) = @_; - # => ($h, $priority); + # => ($h, $priority, $ch); my $s= $ei->{Step}; my $sum_core= $ei->{SummaryCore}; $sum_core= $ei->{Summary} if !defined $sum_core; @@ -998,7 +998,9 @@ END my @worstrow1; my @worstrow2; foreach my $col (@cols) { - my @worst=(' bgcolor="#444444">',0); + # @worst = ( $cell_html->(stuff), $failing_stepid_html ) = + # ($step_cell_html, $priority, $colour_attr, $failing_stepid_html) + my @worst=('',0,'bgcolor="#444444"',''); foreach my $rowix (0..$#{ $fi->{GridRows} }) { my $ei= $fi->{GridGrid}{$col}[$rowix]; next unless $ei; -- 1.7.10.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel