Chun Yan Liu writes ("Re: [PATCH V5 2/7] libxl_read_file_contents: add new entry to read sysfs file"): > >>> On 6/30/2015 at 05:08 PM, in message > <21906.23698.778991.627...@mariner.uk.xensource.com>, Ian Jackson > <ian.jack...@eu.citrix.com> wrote: > > Maybe sysfs will grow support for bigger files in the future. (Also, > > that is actually a description of the kernel internals, not of the > > syscall API). > > Yes, that's about kernel internals. But syscall API will finally call > kernel implementation. From those description, we knows why > fstat always return size 4096 (on x86_64, although actual file > content length is less). And it's not possible the file is changed > into a bigger size during we are reading it. About whether it'll > be changed in future, really don't know.
Right. My point was that an internals document is a poor guide to future behaviour. So, > As to adding a check, it's certainly OK. I can update. Yes, please. Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel