Ian Campbell writes ("Re: [OSSTEST PATCH 08/13] Reporting: Break out
report_blessingscond"):
> Acked-by: Ian Campbell <ian.campb...@citrix.com>
Thanks.
> BTW, I noticed that your valid blessing regex here includes "-", which
> is not allowed elsewhere, which breaks "./standalone make-flight -f
> $branch $branch" for our common branch names meaning the flight name
> needs some munging. A minor inconvenience, but if this check were moved
> to a centralised helper it could be easily fixed...
I guess. Do we have anywhere else that validates a blessing name ?
This particular bit of code is just intended a safety catch to stop
the SQL going wrong.
IMO `-' is valid in blessings. Consider `commission-oseleta'.
> Or at least this was once the case, I can't see the problematic check
> right now and haven't actually tried this for a while. Perhaps it got
> fixed already and I didn't notice?
I'm not sure what check exactly you are referring to...
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
