Wen Congyang writes ("Re: [PATCH 12/35] libxl: events: Make timeout and async
exec setup take an ao, not a gc"):
> On 06/26/2015 01:44 AM, Ian Jackson wrote:
> > All the callers follow the obvious patterns and therefore supply the
> > ao's gc to libxl__async_exec_start and the timeout setup functions.
> > There is therefore no functional change in this patch.
>
> Sorry, I just reviewed this patch, and don't do a building test.
> libxl__async_exec_start() is also used in libxl_netbuffer.c.
Right. This is my fault, not yours. A reviewer is not normally
expected to do a build test.
I should have done a `git grep' to check I had changed the call sites,
but obviously I either failed to do so or overlooked this call site.
I should remember that libxl is starting to grow quite a few areas of
conditional compilation.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
