On 25/06/15 14:14, Vijay Kilari wrote: > On Mon, Jun 22, 2015 at 6:51 PM, Jan Beulich <jbeul...@suse.com> wrote: >>>>> On 22.06.15 at 14:01, <vijay.kil...@gmail.com> wrote: >>> From: Vijaya Kumar K <vijaya.ku...@caviumnetworks.com> >>> >>> XENLOG_ERR_RATE_LIMIT and XENLOG_G_ERR_RATE_LIMIT >>> log levels are added to support rate limit for error messages >> If you mean to say that rate limiting currently doesn't work for >> XENLOG_ERR messages, then that's a problem to be fixed by >> adjusting existing code, not by adding yet another log level. > For GUEST messages ERR and WARN are rate limited by > setting lower threshold to 0 and upper threshold to 2 as below > > #define XENLOG_GUEST_UPPER_THRESHOLD 2 /* Do not print INFO and DEBUG */ > #define XENLOG_GUEST_LOWER_THRESHOLD 0 /* Rate-limit ERR and WARNING */ > > So do you recommend to set same threshold levels to Xen messages > there by ERR & WARN are rate limited?
Xen already has guest rate limiting logic, which has separate visible and ratelimited boundaries. http://xenbits.xen.org/docs/unstable/misc/xen-command-line.html Look at guest_loglvl. If the existing logic isn't working then it should be fixed. We should not introduce a second way of doing this. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
