On 06/24/2015 09:15 AM, Lengyel, Tamas wrote: >> +bool_t p2m_set_altp2m_mem_access(struct domain *d, uint16_t idx, >> + unsigned long pfn, xenmem_access_t >> access) >> +{ >> > > This function IMHO should be merged with p2m_set_mem_access and should be > triggerable with the same memop (XENMEM_access_op) hypercall instead of > introducing a new hvmop one.
I think we should vote on this. My view is that it makes XENMEM_access_op too complicated to use. It also makes using this one specific altp2m capability different to using any of the others -- especially if we adopt Andrew's suggestion and make all the altp2m ops subops. Ed _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel