>>> On 22.06.15 at 18:00, <vkuzn...@redhat.com> wrote: > "Jan Beulich" <jbeul...@suse.com> writes: > >>>>> On 03.06.15 at 15:35, <vkuzn...@redhat.com> wrote: >>> @@ -1129,8 +1129,9 @@ void unmap_vcpu_info(struct vcpu *v) >>> mfn = v->vcpu_info_mfn; >>> unmap_domain_page_global((void *) >>> ((unsigned long)v->vcpu_info & PAGE_MASK)); >>> - >>> - v->vcpu_info = &dummy_vcpu_info; >>> + v->vcpu_info = ((v->vcpu_id < XEN_LEGACY_MAX_VCPUS) >>> + ? (vcpu_info_t *)&shared_info(d, vcpu_info[v->vcpu_id]) >> >> Is this cast really needed? >> > > Without it my gcc-4.8.3 complains: > > domain.c: In function ‘unmap_vcpu_info’: > domain.c:1158:21: error: pointer type mismatch in conditional expression > [-Werror] > : &dummy_vcpu_info); > ^ > cc1: all warnings being treated as errors
Which is the kind of warning one normally should _not_ work around by adding a cast. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
