On 18/06/15 16:55, Don Slutz wrote: > gdbsx_guest_mem_io() does not get d passed, it expects to handle > the domain lookup itself. > > Signed-off-by: Don Slutz <dsl...@verizon.com> > CC: Don Slutz <don.sl...@gmail.com>
As for the change itself, Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com> However, I think the commit message needs improving. Specifically, the caller of XEN_DOMCTL_gdbsx_guestmemio is expected to use DOMID_IDLE to interact with the hypervisor, rather than a domain, which doesn't interact well with with the domain rcu lock. > --- > xen/common/domctl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/common/domctl.c b/xen/common/domctl.c > index ce517a7..2a2d203 100644 > --- a/xen/common/domctl.c > +++ b/xen/common/domctl.c > @@ -443,6 +443,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) > u_domctl) > case XEN_DOMCTL_createdomain: > case XEN_DOMCTL_getdomaininfo: > case XEN_DOMCTL_test_assign_device: > + case XEN_DOMCTL_gdbsx_guestmemio: > d = NULL; > break; > default: _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
