>>> Razvan Cojocaru <rcojoc...@bitdefender.com> 06/04/15 3:46 PM >>> >On 06/04/2015 04:43 PM, Tim Deegan wrote: >> At 14:40 +0100 on 04 Jun (1433428815), Tim Deegan wrote: >>> At 16:45 +0300 on 29 May (1432917959), Razvan Cojocaru wrote: >>>> As suggested by Andrew Cooper, this patch attempts to remove >>>> some redundancy and allow for an easier time when adding vm_events >>>> for new control registers in the future, by having a single >>>> VM_EVENT_REASON_WRITE_CTRLREG vm_event type, meant to serve CR0, >>>> CR3, CR4 and (newly introduced) XCR0. The actual control register >>>> will be deduced by the new .index field in vm_event_write_ctrlreg >>>> (renamed from vm_event_mov_to_cr). The patch has also modified >>>> the xen-access.c test - it is now able to log CR3 events. >>>> >>>> Signed-off-by: Razvan Cojocaru <rcojoc...@bitdefender.com> >>>> Acked-by: Jan Beulich <jbeul...@suse.com> >>> >>> Acked-by: Tim Deegan <t...@xen.org> >> >> Ah, I see I've acked an old version. The ack stands for v9, whough if >> you're going to v10, can you please rename the macro to, e,g, >> >> #define hvm_event_crX(what, new, old) \ >> hvm_event_cr(VM_EVENT_X86_##what, new, old) > >Of course, if Jan (who originally proposed the macro) doesn't have any >objections, I'll rename it.
While I personally think it's better the way it is now, I don't object to it being renamed, even less so considering that Tim is the maintainer of that code and hence should have the final say. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
