On Thu, May 28, 2015 at 02:26:03PM +0100, Jan Beulich wrote:
>
> > --- a/xen/include/public/sysctl.h
> > +++ b/xen/include/public/sysctl.h
> > @@ -694,6 +694,20 @@ struct xen_sysctl_pcitopoinfo {
> > typedef struct xen_sysctl_pcitopoinfo xen_sysctl_pcitopoinfo_t;
> > DEFINE_XEN_GUEST_HANDLE(xen_sysctl_pcitopoinfo_t);
> >
> > +#define XEN_SYSCTL_PSR_CAT_get_l3_info 0
> > +struct xen_sysctl_psr_cat_op {
> > + uint32_t cmd; /* IN: XEN_SYSCTL_PSR_CAT_* */
> > + uint32_t target; /* IN: socket to be operated on */
>
> If this is always the socket number, why would the variable be
> named anything other than "socket". If otoh subsequent patches
> use it differently, I think the comment should be omitted now
> rather than being dropped then (or it should be given its final
> wording from the beginning).
Or 'target to be operated on'?
Chao
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
