>>> On 22.05.15 at 14:57, <andrew.coop...@citrix.com> wrote: > On 22/05/15 13:48, Jan Beulich wrote: >> ... resulting from fbeef5570c ("x86/cpuidle: get accurate C0 value with >> xenpm tool"). >> >> Reported-by: Andrew Cooper <andrew.coop...@citrix.com> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > This appears to fix the issue. > > However, looking at the other cases which play the same games, 0 is used > in preference to -1, given a zero last_state. It would seem logical to > follow suit here (although it is just a debugkey so I am not overly fussed).
I have to admit that within that function (print_acpi_power()) I don't see any "other cases which play the same games". Or are you referring to pmstat_get_cx_stat()? While we shouldn't screw up stat->last there, I think I agree that we also should account things to C0 when we really don't know where things belong. V2 getting ready... Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel