Hi Jan,
On 22/05/2015 07:53, Jan Beulich wrote:
On 22.05.15 at 01:16, <julien.gr...@citrix.com> wrote:
--- a/xen/arch/x86/apic.c
+++ b/xen/arch/x86/apic.c
@@ -992,7 +992,7 @@ void __init init_apic_mappings(void)
apic_phys = mp_lapic_addr;
set_fixmap_nocache(FIX_APIC_BASE, apic_phys);
- apic_printk(APIC_VERBOSE, "mapped APIC to %08lx (%08lx)\n", APIC_BASE,
+ apic_printk(APIC_VERBOSE, "mapped APIC to %08llx (%08lx)\n", APIC_BASE,
Please use 'L' as the shorter equivalent.
I didn't know this shorthand. I will use %Lx
--- a/xen/include/xen/config.h
+++ b/xen/include/xen/config.h
@@ -70,7 +70,7 @@
#define __bitwise
#define MB(_mb) (_AC(_mb, UL) << 20)
-#define GB(_gb) (_AC(_gb, UL) << 30)
+#define GB(_gb) (_AC(_gb, ULL) << 30)
So why do you leave MB() alone? It obviously suffers from the same
problem (perhaps only latent at this point, but anyway).
Because I haven't had any problem with MB. I will resend a new version
with the 2 fixes.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
